feat: Enable single stack deployments in Helm chart#828
Open
jochenseeber wants to merge 1 commit intoopenebs:developfrom
Open
feat: Enable single stack deployments in Helm chart#828jochenseeber wants to merge 1 commit intoopenebs:developfrom
jochenseeber wants to merge 1 commit intoopenebs:developfrom
Conversation
58f43c6 to
c91ec10
Compare
| - "--cache-period={{ .Values.base.cache_poll_period }}"{{ if .Values.base.jaeger.enabled }} | ||
| - "--jaeger={{ include "jaeger_url" . }}"{{ end }} | ||
| - "--grpc-server-addr=[::]:50051" | ||
| - "--grpc-server-addr=[{{ include "bind_address" . }}]:50051" |
Member
There was a problem hiding this comment.
Does this work for ipv4? [0.0.0.0]:50051
IIRC this syntax is only supported on ipv6 or am I misremembering?
Signed-off-by: Jochen Seeber <jochen@seeber.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a global
ipFamilysetting to the Helm chart that controls IP familyconfiguration for all chart-managed Kubernetes Services and adjusts container
bind addresses accordingly.
The setting accepts three values:
ipv4-- IPv4 SingleStack, services bind to0.0.0.0ipv6-- IPv6 SingleStack, services bind to::both(default) -- PreferDualStack with IPv4 and IPv6, services bind to::Two new helper templates are added to
_helpers.tpl:service_ip_family-- generatesipFamilyPolicyandipFamiliesfieldsfor Service specs
bind_address-- returns the appropriate bind address (0.0.0.0or::)All four chart-managed Services now include the
service_ip_familyhelper,and four hardcoded
[::]bind addresses in container args are replaced withthe
bind_addresshelper.Invalid values (including empty string) are rejected at template time with an error message.
Motivation and Context
The chart previously hardcoded
[::]as the bind address and did not setipFamilyPolicyoripFamilieson any Service. This made deployments onIPv4-only fail, with no way to correctly configure the components.
Regression
No
How Has This Been Tested?
Verified with
helm templatefor all supported values:both): All 4 Services render withipFamilyPolicy: PreferDualStackandipFamilies: [IPv4, IPv6]. Bind addresses render as[::].ipv4: All 4 Services render withipFamilyPolicy: SingleStackandipFamilies: [IPv4]. Bind addresses render as[0.0.0.0].ipv6: All 4 Services render withipFamilyPolicy: SingleStackandipFamilies: [IPv6]. Bind addresses render as[::].helm template --set ipFamily=invalidfails with errorinvalid ipFamily value "invalid" -- valid values: ipv4, ipv6, both.helm template --set ipFamily=""fails with the samevalidation error.
Types of changes
Checklist: